[typescript-axios]: slim down jsdoc#21776
Merged
macjohnny merged 6 commits intoOpenAPITools:masterfrom Aug 20, 2025
Merged
Conversation
f8b24e1 to
0c11661
Compare
0c11661 to
bd843a3
Compare
6 tasks
Member
|
FYI this would supersede #21754 |
macjohnny
reviewed
Aug 20, 2025
| @@ -1 +1 @@ | |||
| 7.15.0-SNAPSHOT | |||
| 7.13.0-SNAPSHOT | |||
Member
There was a problem hiding this comment.
please merge the latest master to re-generate all samples. that should revert this line
Contributor
Author
There was a problem hiding this comment.
updated and force-pushed in 85aa155 (#21776)
bd843a3 to
85aa155
Compare
6 tasks
Goopher
pushed a commit
to Goopher/openapi-generator
that referenced
this pull request
Sep 9, 2025
* feat: remove `@export` and more * feat: remove `@memberof` * feat: only add description jsdoc if it exists * feat: remove obvious `@type` * feat: only display JSDoc when `description` OR `deprecated` exists * chore: update generator output --------- Co-authored-by: nocontribute <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typescript axios template had redundant JSDoc tags. made generated openapi client much slimmer by
@deprecated)resolves #21717
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)